Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new translation class to address NF -> Nomad conversion #29

Closed
abhi18av opened this issue Mar 12, 2024 · 3 comments
Closed

Create a new translation class to address NF -> Nomad conversion #29

abhi18av opened this issue Mar 12, 2024 · 3 comments
Milestone

Comments

@abhi18av
Copy link
Member

@jagedn initially suggested a new TaskResource class addressing this translation layer.

I do think that we can explore the idea regarding a specific "translation" class which covers all aspects of NomadJobDefinition from a NextflowTask, however I suggest that we still continue the current iterations and revisit this once the plugin has stabilised in its design - what do you think?

Originally posted by @abhi18av in #27 (comment)

@abhi18av abhi18av added this to the v0.1.0 milestone Mar 12, 2024
@jagedn
Copy link
Collaborator

jagedn commented Mar 13, 2024

I like your implementation in NomadService using the TaskRun , in this way the complexity to build a NomadJob is hidden to NextflowTask so by the moment I think is a good approach

@jagedn
Copy link
Collaborator

jagedn commented Aug 29, 2024

I think this issue is more than covered in current version and we can close it @abhi18av ?

@abhi18av
Copy link
Member Author

Agreed Jorge, all the foundations are in he plug-in already 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants