fix: focus issue on translate modal, remove duplicate code

Signed-off-by: Luka Trovic <[email protected]>

cypress/e2e/Assistant.spec.js

@@ -73,4 +73,28 @@ describe('Assistant', () => {
 			.should('be.visible')
 			.should('contain', 'Hello World')
 	})
+
+	it('Open translate dialog', () => {
+		cy.isolateTest({
+			sourceFile: fileName,
+		})
+		cy.openFile(fileName, { force: true })
+
+		cy.getContent()
+			.click({ force: true })
+		cy.get('[data-cy="assistantMenu"]')
+			.click()
+		cy.get('[data-cy="open-translate"]')
+			.should('be.visible')
+			.click()
+
+		cy.get('[data-cy="translate-input"]')
+			.should('be.visible')
+			.click()
+		cy.get('[data-cy="translate-input"]')
+			.should('be.visible')
+			.type('Hello World')
+		cy.get('[data-cy="translate-input"]')
+			.should('be.focused')
+	})
 })

cypress/e2e/share.spec.js

@@ -117,7 +117,7 @@ describe('Open test.md in viewer', function() {
 				cy.getModal().getContent().should('contain', 'Hello world')
 				cy.getModal().getContent().find('h2').should('contain', 'Hello world')
 				cy.getModal().find('.modal-header button.header-close').click()
-				cy.get('.modal-mask').should('not.exist')
+				cy.get('.modal-mask').should('not.be.visible')
 				// cy.get('#rich-workspace').getContent().should('contain', 'Hello world')
 			})
 	})

src/components/Assistant.vue

@@ -43,7 +43,7 @@
 					</template>
 					{{ provider.name }}
 				</NcActionButton>
-				<NcActionButton close-after-click @click="openTranslateDialog">
+				<NcActionButton data-cy="open-translate" close-after-click @click="openTranslateDialog">
 					<template #icon>
 						<TranslateVariant :size="20" />
 					</template>
@@ -295,6 +295,9 @@ export default {
 			await this.fetchTasks()
 		},
 		openTranslateDialog() {
+			if (!this.selection.trim().length) {
+				this.$editor.commands.selectAll()
+			}
 			emit('text:translate-modal:show', { content: this.selection || '' })
 		},
 		async openResult(task) {

src/components/Menu/MenuBar.vue

@@ -58,7 +58,7 @@
 				:can-be-focussed="activeMenuEntry === visibleEntries.length"
 				@click="activeMenuEntry = 'remain'">
 				<template #lastAction="{ visible }">
-					<NcActionButton close-after-click v-if="canTranslate" @click="showTranslate">
+					<NcActionButton v-if="canTranslate" close-after-click @click="showTranslate">
 						<template #icon>
 							<TranslateVariant />
 						</template>

src/components/Modal/Translate.vue

@@ -39,6 +39,7 @@
 						:value.sync="input"
 						:label="t('text', 'Text to translate from')"
 						autofocus
+						data-cy="translate-input"
 						input-class="translate-textarea"
 						resize="none"
 						@focus="onInputFocus" />