Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old hack from App.vue #2660

Closed
RayBB opened this issue Aug 22, 2024 · 2 comments
Closed

Remove old hack from App.vue #2660

RayBB opened this issue Aug 22, 2024 · 2 comments

Comments

@RayBB
Copy link
Contributor

RayBB commented Aug 22, 2024

Is your feature request related to a problem? Please describe.

I was looking through the code and noticed a section that was mentioned as a hack here.

I was curious if it was still needed and the issue it mentions being a hack for says this is no longer needed.

First added back in 2020, perhaps these few lines of code can be removed?

Describe the solution you'd like

Remove the extra code

Describe alternatives you've considered

It could be left there. That would probably be fine, but as I was digging around to look how I might implement some PWA improvements for #2516 I noticed this and thought I'd look into it.

Additional context

I have not tested removing the "hack" myself.

@raimund-schluessler
Copy link
Member

I think it still cannot go completely. While it seems to work ok, the sortorder dropdown would gain a unnecssary scrollbar without these CSS lines.

@RayBB
Copy link
Contributor Author

RayBB commented Aug 22, 2024

Drats, thanks for checking.

@RayBB RayBB closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants