Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(external_storage): Cast id to int #49466

Open
wants to merge 2 commits into
base: stable28
Choose a base branch
from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Nov 25, 2024

Backport of #49464

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Nov 25, 2024
@backportbot backportbot bot added this to the Nextcloud 28.0.13 milestone Nov 25, 2024
@blizzz blizzz removed this from the Nextcloud 28.0.13 milestone Dec 5, 2024
@blizzz
Copy link
Member

blizzz commented Dec 5, 2024

@marcelklehr keep or close?

@marcelklehr
Copy link
Member

Keep. Still needs fixing

@marcelklehr marcelklehr marked this pull request as ready for review December 6, 2024 07:43
@marcelklehr marcelklehr enabled auto-merge December 6, 2024 08:03
@blizzz blizzz disabled auto-merge December 6, 2024 13:46
follow up to #49218

Signed-off-by: Marcel Klehr <[email protected]>

[skip ci]
Signed-off-by: Marcel Klehr <[email protected]>
@blizzz blizzz force-pushed the backport/49464/stable28 branch from 865b148 to ed895e2 Compare December 6, 2024 13:46
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking as 28 is de facto EOL

@marcelklehr
Copy link
Member

lol, alright then.

@marcelklehr marcelklehr closed this Dec 6, 2024
@marcelklehr marcelklehr reopened this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants