From d7c6108adc3498b6c7c6ace7f99188f6866eeec9 Mon Sep 17 00:00:00 2001
From: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
Date: Thu, 27 Jun 2024 03:15:50 +0200
Subject: [PATCH] fixup! Feat: phishing detection

Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
---
 lib/PhishingDetectionList.php                 | 21 +-----
 lib/PhishingDetectionResult.php               | 22 +-----
 .../PhishingDetection/ContactCheck.php        | 28 ++------
 .../PhishingDetection/CustomEmailCheck.php    | 22 +-----
 lib/Service/PhishingDetection/DateCheck.php   | 24 ++-----
 .../PhishingDetectionService.php              | 22 +-----
 .../PhishingDetection/ReplyToCheck.php        | 22 +-----
 src/components/PhishingWarning.vue            | 22 +-----
 ...hishingDetectionServiceIntegrationTest.php | 20 +-----
 .../Service/Phishing/ContactCheckTest.php     | 72 +++++++++++++++++++
 .../Service/Phishing/CustomEmailCheckTest.php | 49 +++++++++++++
 tests/Unit/Service/Phishing/DateCheckTest.php | 68 ++++++++++++++++++
 .../PhishingDetectionServiceTest.php          | 30 ++------
 .../Service/Phishing/ReplyToCheckTest.php     | 50 +++++++++++++
 14 files changed, 269 insertions(+), 203 deletions(-)
 create mode 100644 tests/Unit/Service/Phishing/ContactCheckTest.php
 create mode 100644 tests/Unit/Service/Phishing/CustomEmailCheckTest.php
 create mode 100644 tests/Unit/Service/Phishing/DateCheckTest.php
 rename tests/Unit/Service/{ => Phishing}/PhishingDetectionServiceTest.php (63%)
 create mode 100644 tests/Unit/Service/Phishing/ReplyToCheckTest.php

diff --git a/lib/PhishingDetectionList.php b/lib/PhishingDetectionList.php
index 30ebe1f7c3..802ec1b7ed 100644
--- a/lib/PhishingDetectionList.php
+++ b/lib/PhishingDetectionList.php
@@ -3,25 +3,8 @@
 declare(strict_types=1);
 
 /**
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail;
diff --git a/lib/PhishingDetectionResult.php b/lib/PhishingDetectionResult.php
index ddb9448b43..3cb0bc3842 100644
--- a/lib/PhishingDetectionResult.php
+++ b/lib/PhishingDetectionResult.php
@@ -3,27 +3,9 @@
 declare(strict_types=1);
 
 /**
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- *
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
-
 namespace OCA\Mail;
 
 use JsonSerializable;
diff --git a/lib/Service/PhishingDetection/ContactCheck.php b/lib/Service/PhishingDetection/ContactCheck.php
index 99067331e0..46d219f099 100644
--- a/lib/Service/PhishingDetection/ContactCheck.php
+++ b/lib/Service/PhishingDetection/ContactCheck.php
@@ -2,25 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service\PhishingDetection;
@@ -30,11 +14,7 @@
 use OCP\IL10N;
 
 class ContactCheck {
-	protected IL10N $l10n;
-	private ContactsIntegration $contactIntegration;
-
-
-	public function __construct(ContactsIntegration $contactIntegration, IL10N $l10n) {
+	public function __construct(private ContactsIntegration $contactIntegration, private IL10N $l10n) {
 		$this->l10n = $l10n;
 		$this->contactIntegration = $contactIntegration;
 	}
diff --git a/lib/Service/PhishingDetection/CustomEmailCheck.php b/lib/Service/PhishingDetection/CustomEmailCheck.php
index 5f934043ee..82f2375978 100644
--- a/lib/Service/PhishingDetection/CustomEmailCheck.php
+++ b/lib/Service/PhishingDetection/CustomEmailCheck.php
@@ -2,25 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service\PhishingDetection;
diff --git a/lib/Service/PhishingDetection/DateCheck.php b/lib/Service/PhishingDetection/DateCheck.php
index 846ef496e4..0704d089b8 100644
--- a/lib/Service/PhishingDetection/DateCheck.php
+++ b/lib/Service/PhishingDetection/DateCheck.php
@@ -2,25 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service\PhishingDetection;
@@ -39,7 +23,7 @@ public function __construct(IL10N $l10n, ITimeFactory $timeFactory) {
 	}
 
 	public function run(string $date): PhishingDetectionResult {
-		$now = $this->timeFactory->getDateTime();
+		$now = $this->timeFactory->getDateTime('now');
 		$dt = $this->timeFactory->getDateTime($date);
 		if ($dt > $now) {
 			return new PhishingDetectionResult(PhishingDetectionResult::DATE_CHECK, true, $this->l10n->t("Sent date is in the future"));
diff --git a/lib/Service/PhishingDetection/PhishingDetectionService.php b/lib/Service/PhishingDetection/PhishingDetectionService.php
index 9bc8640375..7c0896daa1 100644
--- a/lib/Service/PhishingDetection/PhishingDetectionService.php
+++ b/lib/Service/PhishingDetection/PhishingDetectionService.php
@@ -2,25 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service\PhishingDetection;
diff --git a/lib/Service/PhishingDetection/ReplyToCheck.php b/lib/Service/PhishingDetection/ReplyToCheck.php
index 220004bc91..c96ce17791 100644
--- a/lib/Service/PhishingDetection/ReplyToCheck.php
+++ b/lib/Service/PhishingDetection/ReplyToCheck.php
@@ -2,25 +2,9 @@
 
 declare(strict_types=1);
 
-/*
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Service\PhishingDetection;
diff --git a/src/components/PhishingWarning.vue b/src/components/PhishingWarning.vue
index 11b77869de..e277d3d317 100644
--- a/src/components/PhishingWarning.vue
+++ b/src/components/PhishingWarning.vue
@@ -1,23 +1,7 @@
 <!--
-  - @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
-  -
-  - @author 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
-  -
-  - @license AGPL-3.0-or-later
-  -
-  - This program is free software: you can redistribute it and/or modify
-  - it under the terms of the GNU Affero General Public License as
-  - published by the Free Software Foundation, either version 3 of the
-  - License, or (at your option) any later version.
-  -
-  - This program is distributed in the hope that it will be useful,
-  - but WITHOUT ANY WARRANTY; without even the implied warranty of
-  - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  - GNU Affero General Public License for more details.
-  -
-  - You should have received a copy of the GNU Affero General Public License
-  - along with this program.  If not, see <http://www.gnu.org/licenses/>.
-  -->
+  - SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
+  - SPDX-License-Identifier: AGPL-3.0-or-later
+-->
 <template>
 	<div class="warning">
 		<div class="warning__title">
diff --git a/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php b/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php
index 60e9a6ed63..53c34a50ff 100644
--- a/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php
+++ b/tests/Integration/Service/Phishing/PhishingDetectionServiceIntegrationTest.php
@@ -1,23 +1,7 @@
 <?php
 /**
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author  2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
 namespace OCA\Mail\Tests\Integration\Service\Phishing;
diff --git a/tests/Unit/Service/Phishing/ContactCheckTest.php b/tests/Unit/Service/Phishing/ContactCheckTest.php
new file mode 100644
index 0000000000..aa7de9c98f
--- /dev/null
+++ b/tests/Unit/Service/Phishing/ContactCheckTest.php
@@ -0,0 +1,72 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\Tests\Unit\Service\Phishing;
+
+use ChristophWurst\Nextcloud\Testing\TestCase;
+
+use OCA\Mail\Service\ContactsIntegration;
+use OCA\Mail\Service\PhishingDetection\ContactCheck;
+use OCP\IL10N;
+
+use PHPUnit\Framework\MockObject\MockObject;
+
+class ContactCheckTest extends TestCase {
+
+	private IL10N|MockObject $l10n;
+	private ContactsIntegration|MockObject $contactsIntegration;
+	private ContactCheck|MockObject $service;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->l10n = $this->createMock(IL10N::class);
+		$this->contactsIntegration = $this->createMock(ContactsIntegration::class);
+		$this->service = new ContactCheck($this->contactsIntegration, $this->l10n);
+	}
+
+	public function testContactInABCorrectEmail(): void {
+		
+		$fn = "John Doe";
+		$email = "jhon@example.com" ;
+		$contacts = [
+			[
+				"email" => ["jhon@example.com"]
+			]
+		];
+		$this->contactsIntegration->method('getContactsWithName')->willReturn($contacts);
+		$result = $this->service->run($fn, $email);
+
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testContactInABWrongEmail(): void {
+		
+		$fn = "John Doe";
+		$email = "jhon@example.com" ;
+		$contacts = [
+			[
+				"email" => ["jhonDoe@example.com"]
+			]
+		];
+		$this->contactsIntegration->method('getContactsWithName')->willReturn($contacts);
+		$result = $this->service->run($fn, $email);
+
+
+		$this->assertTrue($result->isPhishing());
+	}
+
+	public function testContactNotInAB(): void {
+		
+		$fn = "John Doe";
+		$email = "jhon@example.com" ;
+		$contacts = [];
+		$this->contactsIntegration->method('getContactsWithName')->willReturn($contacts);
+		$result = $this->service->run($fn, $email);
+		$this->assertFalse($result->isPhishing());
+	}
+
+}
diff --git a/tests/Unit/Service/Phishing/CustomEmailCheckTest.php b/tests/Unit/Service/Phishing/CustomEmailCheckTest.php
new file mode 100644
index 0000000000..854798d33a
--- /dev/null
+++ b/tests/Unit/Service/Phishing/CustomEmailCheckTest.php
@@ -0,0 +1,49 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\Tests\Unit\Service\Phishing;
+
+use ChristophWurst\Nextcloud\Testing\TestCase;
+
+use OCA\Mail\Service\PhishingDetection\CustomEmailCheck;
+use OCP\IL10N;
+
+use PHPUnit\Framework\MockObject\MockObject;
+
+class CustomEmailCheckTest extends TestCase {
+
+	private IL10N|MockObject $l10n;
+	private CustomEmailCheck|MockObject $service;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->l10n = $this->createMock(IL10N::class);
+		$this->service = new CustomEmailCheck($this->l10n);
+	}
+
+	public function testNoEmail(): void {
+		$email = "jhon@example.com";
+		$result = $this->service->run($email, null);
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testSameEmail(): void {
+		$email = "jhon@example.com";
+		$result = $this->service->run($email, $email);
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testDifferentEmail(): void {
+		$email = "jhon@example.com";
+		$customEmail = "jhondoe@example.com";
+		$result = $this->service->run($email, $customEmail);
+
+		$this->assertTrue($result->isPhishing());
+	}
+
+}
diff --git a/tests/Unit/Service/Phishing/DateCheckTest.php b/tests/Unit/Service/Phishing/DateCheckTest.php
new file mode 100644
index 0000000000..f1dccd30e7
--- /dev/null
+++ b/tests/Unit/Service/Phishing/DateCheckTest.php
@@ -0,0 +1,68 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\Tests\Unit\Service\Phishing;
+
+use ChristophWurst\Nextcloud\Testing\TestCase;
+
+use DateTime;
+use OCA\Mail\Service\PhishingDetection\DateCheck;
+use OCP\AppFramework\Utility\ITimeFactory;
+use OCP\IL10N;
+
+use PHPUnit\Framework\MockObject\MockObject;
+
+class DateCheckTest extends TestCase {
+
+	private IL10N|MockObject $l10n;
+	private DateCheck|MockObject $service;
+	private ITimeFactory|MockObject $time;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->l10n = $this->createMock(IL10N::class);
+		$this->time = $this->createMock(ITimeFactory::class);
+		$this->service = new DateCheck($this->l10n, $this->time);
+	}
+
+	public function testInThePast(): void {
+
+		$this->time->expects($this->exactly(2))
+		->method('getDateTime')
+		->withConsecutive(
+			['now'],
+			["26 June 2024 22:45:34 +0000"]
+		)
+		->willReturnOnConsecutiveCalls(
+			new DateTime('now'),
+			new DateTime('26 June 2024 22:45:34 +0000')
+		);
+		
+		$result = $this->service->run("26 June 2024 22:45:34 +0000");
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testInTheFuture(): void {
+
+
+		$this->time->expects($this->exactly(2))
+		->method('getDateTime')
+		->withConsecutive(
+			['now'],
+			["17 June 3000 22:45:34 +0000"]
+		)
+		->willReturnOnConsecutiveCalls(
+			new DateTime('now'),
+			new DateTime('17 June 3000 22:45:34 +0000')
+		);
+
+		$result = $this->service->run("17 June 3000 22:45:34 +0000");
+
+		$this->assertTrue($result->isPhishing());
+	}
+
+}
diff --git a/tests/Unit/Service/PhishingDetectionServiceTest.php b/tests/Unit/Service/Phishing/PhishingDetectionServiceTest.php
similarity index 63%
rename from tests/Unit/Service/PhishingDetectionServiceTest.php
rename to tests/Unit/Service/Phishing/PhishingDetectionServiceTest.php
index 60758584c9..820c1a17b2 100644
--- a/tests/Unit/Service/PhishingDetectionServiceTest.php
+++ b/tests/Unit/Service/Phishing/PhishingDetectionServiceTest.php
@@ -1,45 +1,25 @@
 <?php
 /**
- * @copyright 2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @author  2024 Hamza Mahjoubi <hamza.mahjoubi221@proton.me>
- *
- * @license GNU AGPL version 3 or any later version
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-namespace OCA\Mail\Tests\Integration\Service\Phishing;
+namespace OCA\Mail\Tests\Unit\Service\Phishing;
 
 use ChristophWurst\Nextcloud\Testing\TestCase;
 use Horde_Mime_Headers;
 use OCA\Mail\PhishingDetectionResult;
 
-use OCA\Mail\Service\ContactsIntegration;
 use OCA\Mail\Service\PhishingDetection\ContactCheck;
 use OCA\Mail\Service\PhishingDetection\CustomEmailCheck;
 use OCA\Mail\Service\PhishingDetection\DateCheck;
 use OCA\Mail\Service\PhishingDetection\PhishingDetectionService;
 use OCA\Mail\Service\PhishingDetection\ReplyToCheck;
-use OCP\IL10N;
 
 use PHPUnit\Framework\MockObject\MockObject;
 
 class PhishingDetectionServiceTest extends TestCase {
 
-	private ContactsIntegration|MockObject $contactsIntegration;
-	private IL10N|MockObject $l10n;
 	private ContactCheck|MockObject $contactCheck;
 	private CustomEmailCheck|MockObject $customEmailCheck;
 	private DateCheck|MockObject $dateCheck;
@@ -48,8 +28,6 @@ class PhishingDetectionServiceTest extends TestCase {
 
 	protected function setUp(): void {
 		parent::setUp();
-		$this->contactsIntegration = $this->createMock(ContactsIntegration::class);
-		$this->l10n = $this->createMock(IL10N::class);
 		$this->contactCheck = $this->createMock(ContactCheck::class);
 		$this->customEmailCheck = $this->createMock(customEmailCheck::class);
 		$this->dateCheck = $this->createMock(DateCheck::class);
@@ -60,7 +38,7 @@ protected function setUp(): void {
 	
 
 	public function testCheckHeadersForPhishing(): void {
-		$headerStream = fopen(__DIR__ . '/../../data/phishing-mail-headers.txt', 'r');
+		$headerStream = fopen(__DIR__ . '/../../../data/phishing-mail-headers.txt', 'r');
 		$parsedHeaders = Horde_Mime_Headers::parseHeaders($headerStream);
 		fclose($headerStream);
 		$this->replyToCheck->expects($this->once())
diff --git a/tests/Unit/Service/Phishing/ReplyToCheckTest.php b/tests/Unit/Service/Phishing/ReplyToCheckTest.php
new file mode 100644
index 0000000000..2505683126
--- /dev/null
+++ b/tests/Unit/Service/Phishing/ReplyToCheckTest.php
@@ -0,0 +1,50 @@
+<?php
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Mail\Tests\Integration\Service\Phishing;
+
+use ChristophWurst\Nextcloud\Testing\TestCase;
+
+use OCA\Mail\Service\PhishingDetection\ReplyToCheck;
+use OCP\IL10N;
+
+use PHPUnit\Framework\MockObject\MockObject;
+
+class ReplyToCheckTest extends TestCase {
+
+	private IL10N|MockObject $l10n;
+	private ReplyToCheck|MockObject $service;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->l10n = $this->createMock(IL10N::class);
+		$this->service = new ReplyToCheck($this->l10n);
+	}
+
+	
+	public function testNoEmail(): void {
+		$email = "jhon@example.com";
+		$result = $this->service->run($email, null);
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testSameEmail(): void {
+		$email = "jhon@example.com";
+		$result = $this->service->run($email, $email);
+
+		$this->assertFalse($result->isPhishing());
+	}
+
+	public function testDifferentEmail(): void {
+		$email = "jhon@example.com";
+		$customEmail = "jhondoe@example.com";
+		$result = $this->service->run($email, $customEmail);
+
+		$this->assertTrue($result->isPhishing());
+	}
+
+}