Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Move delete button away from close and next to picture name #5

Closed
jancborchardt opened this issue Aug 17, 2016 · 3 comments
Closed
Assignees
Milestone

Comments

@jancborchardt
Copy link
Member

Any file actions should go next to the file name. Having the delete button next to the close button will result in misclicks.

In fact the delete action should be behind a 3-dot menu ideally (like in Files), but only makes sense when there are multiple other actions, like download.

cc @manishbisht since you added the delete button. Backport-request because this is a big usability issue.

@jancborchardt jancborchardt added this to the Nextcloud 11.0 milestone Aug 17, 2016
@oparoz
Copy link
Member

oparoz commented Aug 17, 2016

Any file actions should go next to the file name. Having the delete button next to the close button will result in misclicks.

This won't solve the issue. It will be next to other buttons and mistakes will also happen.

In fact the delete action should be behind a 3-dot menu ideally (like in Files)

Same problem. People can still accidentally press that button in the list of options shown in the menu.

So, it seems that moving the button isn't the real solution, there are plenty of examples of very popular online gallery software from large companies (Google, Apple, Microsoft) which show the delete button, right next to other actions.

I suggest we go with the Google approach and turn the exit button into a "back" button and move it to the left. It feels right since the user is effectively sent back to where he/she started.

@manishbisht
Copy link
Contributor

manishbisht commented Aug 18, 2016

I suggest we go with the Google approach and turn the exit button into a "back" button and move it to the left. It feels right since the user is effectively sent back to where he/she started.

It is good to replace the close/button with the back button.

Also when user click on the delete button we can show the confirmation box about deleting the image. So that mistake can't happen.

@skjnldsv
Copy link
Member

skjnldsv commented Sep 3, 2019

Superseded by #540

@skjnldsv skjnldsv closed this as completed Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants