Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow _ping docker api to verify service accessible #3488

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Conversation

andrey18106
Copy link
Contributor

Allow /_ping api in docker-socket-proxy required for app_api to verify docker service connection.

@andrey18106 andrey18106 requested a review from szaimen October 5, 2023 10:18
Signed-off-by: Simon L <[email protected]>
Copy link
Collaborator

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@szaimen
Copy link
Collaborator

szaimen commented Oct 5, 2023

@andrey18106 @bigcat88 does my commit look good as well?

@szaimen szaimen added 3. to review Waiting for reviews bug Something isn't working labels Oct 5, 2023
@szaimen szaimen added this to the next milestone Oct 5, 2023
@bigcat88
Copy link
Member

bigcat88 commented Oct 5, 2023

@andrey18106 @bigcat88 does my commit look good as well?

never mind, I deleted my previous comment, misunderstood.
Yeah, I am fine, it looks more strict :)

@szaimen
Copy link
Collaborator

szaimen commented Oct 5, 2023

All right, thanks! :)

@szaimen szaimen merged commit fd707d0 into main Oct 5, 2023
3 checks passed
@szaimen szaimen deleted the allow-ping-app-api branch October 5, 2023 10:33
@szaimen
Copy link
Collaborator

szaimen commented Oct 5, 2023

This is now released with v7.4.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants