trusted_proxies not set

[wuast94]

i get the error that my trusted_proxies are not set correctly.

'trusted_proxies' => 
  array (
    0 => '127.0.0.1',
    1 => '::1',
    10 => '',
  ),

and indeed they arent, i followed the manual install and run thin in a docker swarm cluster.

[szaimen]

Hi, this is a bug currently and will be fixed with #5666

[wuast94]

im pretty sure that this will not fix the problem, i am using the nextcloud-aio network, and the pr didnt change more than adding this back.

BUT it could be becouse i am using a second network for my traefik proxy attached to the apache container with

networks:
      - nextcloud-aio
      - proxy_t2_proxy

[wuast94]

also my nextcloud container is in the nextcloud-aio network and in another one i need for some special access.
also becouse it wasnt that clear, all my nextcloud containers are in the nextcloud-aio network

[szaimen]

Hey, thanks for coming back to me. You are right. This is not the correct fix.
See

all-in-one/Containers/nextcloud/entrypoint.sh

Lines 596 to 600 in 6e2a14f

	IPv4_ADDRESS="$(dig nextcloud-aio-nextcloud A +short +search | head -1)"
	# Bring it in CIDR notation
	# shellcheck disable=SC2001
	IPv4_ADDRESS="$(echo "$IPv4_ADDRESS" | sed 's|[0-9]\+$|0/16|')"
	php /var/www/html/occ config:system:set trusted_proxies 10 --value="$IPv4_ADDRESS"

[wuast94]

i think the dig itself in a swarm cluster isnt the best way anyway, espacially with multiple networks attached to it i guess.

maybee we could add a ENV to "hardcode" the IPv4_ADDRESS variable? but this also dont sound like the right way. the only ip adress that matters here is the one of the reverse proxy, but this one cant nextcloud know becouse the apache container is in beetween and "isolates" the two.

wgat do you think about this @szaimen ? catch me if im missing anything or didnt understand right :)

i would be happy to make a PR for this.

[szaimen]

This will be adjusted with #5671