3단계 - 수강신청(DB 적용) #647
Open
3단계 - 수강신청(DB 적용) #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shared-moon
requested changes
Nov 6, 2024
src/main/resources/schema.sql
Outdated
| price int, | ||
| title varchar(255), | ||
| primary key (id), | ||
| foreign key (course_id) references course (id) |
There was a problem hiding this comment.
실무에서 외래키를 안쓰는 이유 를 한번 검색해보시고 어떤 방향으로 진행할지 생각해보시면 좋을 것 같네요!
저는 개인적으론 얕은 관계만 유지해도 충분하다고 생각합니다!
| private final int width; | ||
| private final int height; | ||
| private Long id; | ||
| private int sessionId; |
| import java.time.LocalDate; | ||
|
|
||
| public class PaidSession extends Session { | ||
| private int maxEnrollment; |
There was a problem hiding this comment.
필드를 굳이 구현체에 따라 나눌 필요가 있을까요 ? 디비상으로는 무료강의도 값을 가지고 있긴 할텐데요!
| } | ||
|
|
||
| @Override | ||
| public void enroll(int payment) { |
There was a problem hiding this comment.
요거는 꼭 그래야되는 건 아닌데, 유효성검사의 책임을 다른 클래스로 위임하는건 어떨까요 ?
type에 따라 유효성검사를 결정하는 팩토리 클래스를 두면 굳이 세션 자체를 확장하지 않아도 구현이 가능할 것 같아서요!
DB랑 연동하게 되면 Session이 엔티티 클래스가 되는데 혼잡해지지 않을까 해서 의견드려봤습니다 ~
| image.setId(keyHolder.getKey().longValue()); | ||
| } | ||
|
|
||
| return 1; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님,
늦었지만 3단계 진행하여 올립니다.
수정 필요한 부분 코멘트 남겨주시면 감사하겠습니다!