재성님 안녕하세요! lms 마지막 요구사항 변경 부분 진행해봤습니다! #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javajigi
requested changes
Dec 23, 2023
| import java.util.List; | ||
| import java.util.Set; | ||
|
|
||
| public class CoverImages { |
Comment on lines
25
to
30
| this.id = id; | ||
| this.title = title; | ||
| this.coverImages.addAll(coverImages); | ||
| this.lectureStatus = LectureStatus.YET; | ||
| this.lectureRecruitingStatus = lectureRecruitingStatus; | ||
| this.registrationPeriod = registrationPeriod; |
There was a problem hiding this comment.
중복 제거를 위해 부생성자가 주생성자를 호출해 인스턴스 변수 값을 초기화할 것을 추천
| public boolean recruiting() { | ||
| return LectureStatus.RECRUITING.equals(this.lectureStatus); | ||
| public boolean isRecruiting() { | ||
| return LectureRecruitingStatus.RECRUITING.equals(this.lectureRecruitingStatus); |
There was a problem hiding this comment.
Suggested change
| return LectureRecruitingStatus.RECRUITING.equals(this.lectureRecruitingStatus); | |
| return lectureRecruitingStatus.isRecruiting(); |
enum 또한 객체라 메시지를 보내 구현 가능함
Comment on lines
4
to
8
| RECRUITING("RECRUITING") | ||
| , CLOSING("CLOSING") | ||
| , PREPARING("PREPARING") | ||
| , NO_MATCH("NO_MATCH") | ||
| ; |
There was a problem hiding this comment.
Suggested change
| RECRUITING("RECRUITING") | |
| , CLOSING("CLOSING") | |
| , PREPARING("PREPARING") | |
| , NO_MATCH("NO_MATCH") | |
| ; | |
| RECRUITING("RECRUITING"), | |
| CLOSING("CLOSING"), | |
| PREPARING("PREPARING"), | |
| NO_MATCH("NO_MATCH"); |
위와 같이 스타일로 구현하는 것도 가능함
Comment on lines
+88
to
89
| Lecture lecture = new PaidLecture(0L, "test", coverImage, LectureRecruitingStatus.PREPARING, | ||
| new RegistrationPeriod(startDate, endDate), new Price(BigDecimal.TEN), maxStudent); |
There was a problem hiding this comment.
Lecture 객체와 같이 인스턴스 변수가 많은 객체를 테스트하려면 객체를 생성하는데 어려움이 있다.
중복 코드 또한 많이 발생해 Lecture를 생성할 때 생성자의 인자가 변경되는 경우 변경할 부분이 많아진다.
https://www.arhohuttunen.com/test-data-builders/ 문서 참고해 Lecture와 같이 복잡한 객체의 테스트 데이터를 생성할 때 어떤 방법을 사용할 것인지 선택해 보면 좋겠다.
이번 기회에 내가 선호하는 방법을 적용해 보고 앞으로도 쭈욱 활용하는 방식이면 좋겠다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
기존 코드를 짤 때 '수강 신청 도메인' 없이 선발 인원 리스트에 없으면 수강 신청을 못하게 해놔서 수강신청 취소에 대한 기능을 넣지 않았습니다!
리뷰 부탁드립니다 😄