Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update supported Python versions #37

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Update supported Python versions #37

merged 2 commits into from
Jun 5, 2024

Conversation

adamltyson
Copy link
Member

No description provided.

@adamltyson adamltyson requested a review from a team June 5, 2024 15:56
niksirbi
niksirbi approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why drop py3.9? Is it reaching EOL already?

@niksirbi
Copy link
Member

niksirbi commented Jun 5, 2024

Also, perhaps related, the python version shield displayed in the README seems to point to cellfinder on PyPI, instead of fancylog. So maybe that shield will no longer display the correct info after the bump?

@niksirbi
Copy link
Member

niksirbi commented Jun 5, 2024 •
edited
Loading

Why drop py3.9? Is it reaching EOL already?

NVM, just saw the SPEC

@adamltyson
Copy link
Member Author

Also, perhaps related, the python version shield displayed in the README seems to point to cellfinder on PyPI, instead of fancylog. So maybe that shield will no longer display the correct info after the bump?

Thanks, just fixed it (must have copied and pasted years ago!).

@adamltyson adamltyson merged commit 5d55f64 into main Jun 5, 2024
21 checks passed
@adamltyson adamltyson deleted the python-versions branch June 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niksirbi niksirbi niksirbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamltyson @niksirbi