Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

green ring NFT on catalog has a duplicate #54

Open
TimDaub opened this issue Sep 29, 2022 · 4 comments
Open

green ring NFT on catalog has a duplicate #54

TimDaub opened this issue Sep 29, 2022 · 4 comments

Comments

@TimDaub
Copy link
Collaborator

TimDaub commented Sep 29, 2022

Greenring posted on Discord:

"""
Also, while I'm here, I have a specific question regarding making small corrections to neume. A duplicate of my song 'The Leap' was somehow minted by someone else on the catalog contract after me. Not really sure how it happened, but it went up right after I minted mine. I let catalog know, and it looks like they basically blanked out the NFT. The correct token ID on the Catalog contract for the song is 325, the fake one is 327. I only bring it up because there are currently two copies of the song showing on MusicOS so I'm guessing neume is indexing both. Just wondering if it is a straightforward or more involved fix to get neume to ignore this specific token.
Correct token:
https://opensea.io/assets/ethereum/0x0bc2a24ce568dad89691116d5b34deb6c203f342/325

Extra/Incorrect token:
https://opensea.io/assets/ethereum/0x0bc2a24ce568dad89691116d5b34deb6c203f342/327
"""

@il3ven commented:

"""
@TimDaub Upon a little inspection, I think this is because we fetch NFT on the block they were created. Catalog must have updated the tokenURI sometime after the mint. In neume, the tokenURI for tokenID 327 is still the old one.
"""

@il3ven do we need a "token ignore file" that we could e.g. set "0x0bc2a24ce568dad89691116d5b34deb6c203f342/325" to ignore?

@il3ven
Copy link
Collaborator

il3ven commented Sep 29, 2022

Should we take care of this on the music-os level? If not, then we will need a token ignore file.

@TimDaub
Copy link
Collaborator Author

TimDaub commented Sep 30, 2022

I think its our responsibility

@il3ven
Copy link
Collaborator

il3ven commented Oct 8, 2022

At what level should we add the token ignore file? We can add it at the call-block-logs level or the music-os-accumulator level. I think it makes sense to be at music-os-accumulator level.

@TimDaub
Copy link
Collaborator Author

TimDaub commented Oct 8, 2022

I think it makes sense to be at music-os-accumulator level.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants