Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors #1906

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors #1906

wants to merge 1 commit into from

Conversation

0lesen
Copy link

@0lesen 0lesen commented Nov 21, 2024

Added Description

@0lesen 0lesen changed the title Update cisco_ios_show_ip_bgp_vpnv4_all_neighbors.textfsm Added description in cisco_ios_show_ip_bgp_vpnv4_all_neighbors Nov 21, 2024
@mjbear
Copy link
Contributor

mjbear commented Nov 21, 2024

I have some suggestions I'll put forth, but that won't be until this evening.
Thank you. 🙂

@mjbear
Copy link
Contributor

mjbear commented Nov 22, 2024

@0lesen
Please provide raw output (which contains a BGP peer Description) in your PR.
(Replace any potentially sensitive information with similar placeholders.)

With that raw output, use the helper scripts to parse that raw output and add that into your PR too.

https://github.com/networktocode/ntc-templates/blob/master/docs/dev/dev_environment.md

Ask if you have questions. Thank you.

I'd be glad to re-review once there's test data. 😁

jmcgill298
jmcgill298 reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @0lesen . As @mjbear requested, please update the test data to make this PR ready for review

@jmcgill298 jmcgill298 added the changes_requested Waiting on user to address feedback label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcgill298 jmcgill298 jmcgill298 left review comments

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changes_requested Waiting on user to address feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0lesen @mjbear @jmcgill298