Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form::validateMaxPostSize() never called #30

Open
Ciki opened this issue Aug 2, 2014 · 3 comments
Open

Form::validateMaxPostSize() never called #30

Ciki opened this issue Aug 2, 2014 · 3 comments
Milestone

Comments

@Ciki
Copy link
Contributor

Ciki commented Aug 2, 2014

I think validateMaxPostSize method is actually never called in case POST data exceeds $_SERVER['CONTENT_LENGTH'].
It is meant to be called from validate() which is called from fireEvents but it can never be called due this condition as it calls https://github.com/nette/application/blob/master/src/Application/UI/Form.php#L108 which returns always FALSE in that case

@JanTvrdik
Copy link
Contributor

How could POST data exceed $_SERVER['CONTENT_LENGTH']? Maybe related https://github.com/nette/nette/pull/793/files

@Ciki
Copy link
Contributor Author

Ciki commented Aug 2, 2014

Yes, it is related, thanks! POST data can be exceeded if you try to upload too large file

@dg
Copy link
Member

dg commented Aug 6, 2014

Hmm, this is related to 2.2, because of this nette/application@1f492cf

@dg dg added this to the v2.4 milestone Feb 16, 2015
@dg dg modified the milestones: v3.0, v2.5 Jun 21, 2017
@dg dg modified the milestones: v3.0, v3.1 Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants