Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix prerender service to work with http://baredomain urls #32

Open
fool opened this issue Sep 16, 2020 · 2 comments
Open

fix prerender service to work with http://baredomain urls #32

fool opened this issue Sep 16, 2020 · 2 comments
Labels
feat/prerender low-priority never_stale type: bug code to address defects in shipped code

Comments

@fool
Copy link
Contributor

fool commented Sep 16, 2020 •
edited by kaganjd
Loading

Right now, if you try to prerender an http:// link, it doesn't work well, as reported in this community thread:

https://community.netlify.com/t/og-twitter-previews-not-working/15066/4

You can see the results even via curl (testmysite.io uses our prerender service):

$ curl -A twitterbot http://testmysite.io ; echo
<html><head></head><body></body></html>
$ curl http://testmysite.io ; echo
Redirecting to https://testmysite.io/

the content on that page isn't blank, even without JS, if we follow the redirect:

$ curl https://testmysite.io/ ; echo
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8" />

This seems to only happen to http links though - https works as expected:

$ curl https://testmysite.io/ ; echo
<!DOCTYPE html>
<html lang="en">
<head>

support follow ups
@fool fool added the bug label Sep 16, 2020
@fool
Copy link
Contributor Author

fool commented Sep 16, 2020

I believe that Pod C owns prerendering based on the pod ownership of features doc which I won't link since this is a public repo, so put on their board for triage. Please let me know if you disagree!

@laurajodz laurajodz added type: bug code to address defects in shipped code low-priority feat/prerender and removed bug labels Sep 23, 2020
@kaganjd
Copy link

kaganjd commented Feb 19, 2021

Business customer frame.io running into this- added ticket above in case we fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat/prerender low-priority never_stale type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fool @rybit @laurajodz @kaganjd