Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not transform HTTP POST requests to GETs for proxy'd paths #27

Open
fool opened this issue Jan 10, 2020 · 2 comments
Open

do not transform HTTP POST requests to GETs for proxy'd paths #27

fool opened this issue Jan 10, 2020 · 2 comments

Comments

@fool
Copy link
Contributor

fool commented Jan 10, 2020

Customer noticed that their function, which differentiates POST handling from GET handling, when used on a site with prerendering configured, translates POST to GET which of course broke the function.

I think we MUST handle POST-as-GET for facebook's tendency to use POST to fetch content and that being most of the point of prerendering, but I think we need not transform it for other services, as a customer demonstrated in https://netlify.zendesk.com/agent/tickets/16082 which has a good repro setup.

@fool
Copy link
Contributor Author

fool commented Jan 23, 2020

from the customer:

Deploy for each:
https://app.netlify.com/sites/webhook-prerender-debug/deploys/5e17847713be790008724477
https://app.netlify.com/sites/webhook-debug-no-prerender/deploys/5e1784fb84f0c10188a514cc

@fool
Copy link
Contributor Author

fool commented Jan 23, 2020

adding this to the traffic & delivery platform board; if that turns out to be the wrong place, please at mention me and remove it from there so I can try to find a better place (I am not sure if it is really a bug in the prerender service where I filed it - I think it might be a proxy bug since we proxy to prerender? Advice sought :))

If you remove it from that board because it isn't yours, and don't say something about doing so, it will get lost and that would be sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants