Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reason to PoolTransactionReject Malformed capacity error #4107

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Add reason to PoolTransactionReject Malformed capacity error #4107

merged 3 commits into from
Aug 18, 2023

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

When send a transaction with (outputs capacity) > (inputs capacity), Reject::Malformed(Overflow) error seems confused for user.

What is changed and how it works?

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner August 17, 2023 12:22
@chenyukang chenyukang requested review from doitian and removed request for a team August 17, 2023 12:22
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Aug 18, 2023
@eval-exec
Copy link
Collaborator

The code failed to compile successfully : https://github.com/nervosnetwork/ckb/actions/runs/5900716919/job/16005514864

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 18, 2023
@chenyukang
Copy link
Collaborator Author

I need to rebase to develop.

@chenyukang chenyukang added this pull request to the merge queue Aug 18, 2023
Merged via the queue into nervosnetwork:develop with commit ec271f8 Aug 18, 2023
33 checks passed
@chenyukang chenyukang mentioned this pull request Aug 21, 2023
Merged
zhangsoledad added a commit that referenced this pull request Aug 21, 2023
@zhangsoledad
Merge pull request #4111 from chenyukang/yukang-port-111-tx-malformed
2c6ee9c 
Backport #4107 to rc/v0.111.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @eval-exec @zhangsoledad