From 4512dc8b448478cfb1b57553140086d2dda4a63d Mon Sep 17 00:00:00 2001
From: yukang <moorekang@gmail.com>
Date: Mon, 14 Aug 2023 11:37:59 +0800
Subject: [PATCH] remove unnecessary clone in rbf

---
 tx-pool/src/pool.rs | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/tx-pool/src/pool.rs b/tx-pool/src/pool.rs
index 82bf11948f..59f3147cf9 100644
--- a/tx-pool/src/pool.rs
+++ b/tx-pool/src/pool.rs
@@ -555,16 +555,12 @@ impl TxPool {
 
         let mut all_statuses = pool_entries.iter().map(|e| e.status).collect::<Vec<_>>();
 
-        let conflicts = pool_entries
-            .iter()
-            .map(|e| e.inner.clone())
-            .collect::<Vec<_>>();
-
         // Rule #2, new tx don't contain any new unconfirmed inputs
         let mut inputs = HashSet::new();
-        for c in conflicts.iter() {
-            inputs.extend(c.transaction().input_pts_iter());
+        for c in pool_entries.iter() {
+            inputs.extend(c.inner.transaction().input_pts_iter());
         }
+
         if rtx
             .transaction
             .input_pts_iter()
@@ -579,8 +575,8 @@ impl TxPool {
         // and the ancestor of the new tx don't have common set with the replaced tx's descendants
         let mut replace_count: usize = 0;
         let ancestors = self.pool_map.calc_ancestors(&short_id);
-        for conflict in conflicts.iter() {
-            let id = conflict.proposal_short_id();
+        for conflict in pool_entries.iter() {
+            let id = conflict.inner.proposal_short_id();
             let descendants = self.pool_map.calc_descendants(&id);
             replace_count += descendants.len() + 1;
             if replace_count > MAX_REPLACEMENT_CANDIDATES {