Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: a construct method for default change builder #109

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

yangby-cryptape
Copy link
Contributor

Note

The simpler it is, the easier it is to make mistakes.

Description

I made a mistake in #108. 😣

Even DefaultChangeBuilder is public, but all its fields are private, users couldn't construct it, outside the ckb-sdk.

This time, I tested in my local machine before submit this PR.

@quake quake merged commit b792ee7 into nervosnetwork:master Mar 18, 2024
10 checks passed
@yangby-cryptape yangby-cryptape deleted the chore/construct branch March 18, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants