Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special cases of node.context.* #44

Open
mhsdesign opened this issue Feb 13, 2024 · 3 comments · May be fixed by #122
Open

Special cases of node.context.* #44

mhsdesign opened this issue Feb 13, 2024 · 3 comments · May be fixed by #122

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Feb 13, 2024 •
edited by dlubitz
Loading

  • migrate node.context.currentSite to eel helper to fetch site entity ✅
  • migrate node.context.workspace to eel helper to fetch workspace, but attention, the workspace api in fusion also changed.
  • warn if anything else is accessed by node.context.*
  • while the renderingMode has a basic migration via TASK: Adjust migration for renderingMode.isEdit #22, but the not all things are migrated currently 🙅 ✅
    • node.context.workspace.name == 'live' -> !renderingMode.isEdit
    • node.context.workspace.personalWorkspace -> renderingMode.isEdit
    • node.context.currentRenderingMode.* -> renderingMode.*
@dlubitz
Copy link
Contributor

dlubitz commented Dec 23, 2024 •
edited
Loading

✅ Already implemented replacements:

- node.context.currentSite
+ Neos.Site.findBySiteNode(site)
- node.context.currentRenderingMode.name
+ renderingMode.name

- node.context.currentRenderingMode.title
+ renderingMode.title

@dlubitz
Copy link
Contributor

dlubitz commented Dec 23, 2024 •
edited
Loading

🙅 From my POV we can't migrate this in the mentioned way, as this is just a wild guess if this was the intention of the code.

node.context.workspace.name == 'live' -> !renderingMode.isEdit
node.context.workspace.personalWorkspace -> renderingMode.isEdit

@dlubitz
Copy link
Contributor

dlubitz commented Dec 23, 2024

migrate node.context.workspace to eel helper to fetch workspace, but attention, the workspace api in fusion also changed.

@mhsdesign Which EEL helper is able to do that?

@dlubitz dlubitz linked a pull request Dec 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEATURE: Improve context rewrites in fusion neos/rector
2 participants
@dlubitz @mhsdesign