Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Use preview renderingMode for page preview #4959

Open
3 tasks
mhsdesign opened this issue Mar 23, 2024 · 0 comments
Open
3 tasks

BUG: Use preview renderingMode for page preview #4959

mhsdesign opened this issue Mar 23, 2024 · 0 comments
Labels
8.3 9.0 Backlog A category for things that are okay to be rather 'hidden'

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Mar 23, 2024

The "Show Preview" button in the content module, as well as the "Open page in 'Foo' workspace" in the workspace module does not work as executed.

image

History

Current state

Currently, we still fetch the renderingMode from the users' session, so the "Show Preview" will still render as edit mode instead of preview. (See todo in the NodeController)

Following new Neos 9 differences to 8.3 currently exist:

These issues also exits in Neos 8.3 and should be fixable via the new renderingMode:

Acceptance criteria

  • The button "Open page in 'Foo' workspace" in the workspace module will use a preview editPreviewMode and evaluate renderingMode.isPreview to true and isEdit to false.
  • The button "Show Preview" in the content module will use a preview editPreviewMode and evaluate renderingMode.isPreview to true and isEdit to false.
  • Navigating inside a preview page will keep the preview renderingMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.3 9.0 Backlog A category for things that are okay to be rather 'hidden'
Projects
None yet
Development

No branches or pull requests

2 participants