Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Remove deprecated Fusion prototypes #4538

Closed
1 task done
mficzel opened this issue Sep 19, 2023 · 2 comments · Fixed by #4537
Closed
1 task done

TASK: Remove deprecated Fusion prototypes #4538

mficzel opened this issue Sep 19, 2023 · 2 comments · Fixed by #4537

Comments

@mficzel
Copy link
Member

mficzel commented Sep 19, 2023

Subtask of #4498

Is there an existing issue for this topic?

  • I have searched the existing issues

Description

The prototypes "Array", "RawArray", "Collection", "RawCollection" and "Attributes" are deprecated since at least Neos 5 and should be removed.

Possible Solution

No response

@mficzel mficzel moved this to In Progress 🚧 in Neos 9.0 Release Board Sep 19, 2023
@mficzel mficzel moved this from In Progress 🚧 to Under Review 👀 in Neos 9.0 Release Board Sep 19, 2023
@mhsdesign
Copy link
Member

Hheheh i found some old fusion inside the neos ui e2e tests which needs to be adjusted ^^ https://github.com/neos/neos-ui/tree/9.0/Tests/IntegrationTests/TestDistribution/DistributionPackages

@github-project-automation github-project-automation bot moved this from Under Review 👀 to Done ✅ in Neos 9.0 Release Board Oct 9, 2023
@bwaidelich
Copy link
Member

@mficzel Thanks again for your great efforts on this one, it feels much cleaner.

I stumbled upon a regression though: Fluid based prototypes that used Attributes now fail with a "Array to string conversion" exception (see Slack discussion).

IMO there are four possible solutions:

a) re-add Neos.Fusion:Attributes and use it for all Fluid based prototypes
b) adjust affected prototypes with some @process magic that converts the arrays
c) replace Prototypes using Fluid with Fusion implementations and remove Fluid dependency from Neos.Fusion
d) adjust affected Fluid templates, e.g. by adding a dedicated AttributesViewHelper

@ahaeslich ahaeslich removed the 9.0beta2 label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants