Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of NodePropertiesWereSet events during inline editing #4387

Closed
bwaidelich opened this issue Jul 7, 2023 · 1 comment · Fixed by neos/neos-ui#3751
Closed

Comments

@bwaidelich
Copy link
Member

Currently when inline-editing a text in the Neos content module, changes are sent to the server during typing leading to sometimes multiple NodePropertiesWereSet properties per second!

This produces needles load and makes rebasing, replays etc. less performant.

A solution might be to compress similar NodePropertiesWereSet events during rebase (see #4263).

But it might be more sensible to avoid the similar commands to be triggered already on the client side:
We could postpone the /neos/ui-services/change request to when the editor has actually finished typing (e.g. on blur and or navigation).
Obviously this is more involved and concerns UX. E.g. the pending changes should probably kept in the local storage such that they are not lost if the browser is closed etc.

Note: I could imagine unsaved text to be highlighted somehow:

image

@mhsdesign
Copy link
Member

With the Neos Ui change: neos/neos-ui#3751 we were able to reduce the events send during inline editing. Additionally on top we still can experiment with compaction on publish #4263 but for now i think we can close this.

@github-project-automation github-project-automation bot moved this from In Progress 🚧 to Done ✅ in Neos 9.0 Release Board Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants