Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for php 8.4's deprecation of implicit nullable types #3411

Open
mhsdesign opened this issue Nov 2, 2024 · 0 comments
Open

Prepare for php 8.4's deprecation of implicit nullable types #3411

mhsdesign opened this issue Nov 2, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

with php 8.4 implicit nullable types are deprecated: https://stitcher.io/blog/new-in-php-84#implicit-nullable-types-deprecation

These are a few usages that i found just in the interfaces:

... and also in neos - https://github.com/neos/neos-development-collection/blob/ee36cc29460aa2005a22b577080a85ba505a6d1f/Neos.Neos/Classes/Service/DataSource/DataSourceInterface.php#L44

As i tested it should be non breaking to adjust PropertyMappingConfigurationInterface $configuration = null to be PropertyMappingConfigurationInterface|null $configuration = null event if someone implemented it and doesnt use |null yet. That seems to be possible because the implementation narrows the type which seams legal in php. Meaning we can actually adjust that at any time so Flow 9.0 would be php8.4 compatible in that aspect at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant