Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: TranslationParameterToken's translate() argument has no impact #3380

Open
1 task done
martinlipp opened this issue Jul 23, 2024 · 0 comments
Open
1 task done
Labels

Comments

@martinlipp
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The translate() method in the Neos\Flow\I18n\EelHelper\TranslationParameterToken class has an $overrides argument which is ineffective, because the result of the array_replace_recursive() call is not used to replace the array. (The argument is never used in Flow, so it does not lead to any obviously visible bugs within Flow.)

array_replace_recursive($this->parameters, $overrides);

Expected Behavior

The $overrides argument should work as expected. This should work:
$this->parameters = array_replace_recursive($this->parameters, $overrides);

Steps To Reproduce

No response

Environment

- Flow: 9.0
- PHP: 8.1

Anything else?

No response

@martinlipp martinlipp added the Bug label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant