Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User agents for VersionCheck are missing information #49

Open
LordRalex opened this issue Dec 13, 2023 · 0 comments
Open

User agents for VersionCheck are missing information #49

LordRalex opened this issue Dec 13, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@LordRalex
Copy link

LordRalex commented Dec 13, 2023

With the changes to Neo + FML, there is now much less information being sent into the User Agent. Notably, it is now missing the Minecraft version (previously included in the version itself) along with the actual implementation that is using FML. Accurately, the version it has provided is not even for FML, but for NeoForge. This means it is misleading.

Prior Example:
Java-http-client/17.0.1 MinecraftForge/1.18.2-40.2.13 journeymap/5.9.7

Current:
Java-http-client/17.0.9 FancyModLoader/47.1.47 extendedslabs/3.0.1

At the least it would be nice if "Minecraft/" was added to this User-Agent, so that it can be determined which version of the game is calling it.

Additionally, FML should not be the name, but it should be NeoForge instead.

Preferred:
Java-http-client/17.0.1 NeoForge/47.1.47 Minecraft/1.20.4 journeymap/5.9.7

Acceptable:
Java-http-client/17.0.1 NeoForge/1.20.4-47.1.47 journeymap/5.9.7

@sciwhiz12 sciwhiz12 added the enhancement New feature or request label Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants