Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic naming of the choose module button with just numbers can cause event collisions with other scenarios/mods that do the same #1

Open
Soggs opened this issue Mar 16, 2022 · 0 comments

Comments

@Soggs
Copy link
Contributor

Soggs commented Mar 16, 2022

I ran into this issue with our Redmew scenario and Module Inserter. I have since fixed the Redmew side of things but I though I should also let you know of it to prevent possible issues in the future.

In that specific case clicking the second module button in the MI Interface would also trigger the event to show/close our scenario info screen. Short video of that here: https://cdn.discordapp.com/attachments/306402592265732098/952640374973812746/2022-03-13_19-47-00.mp4

This happend as both buttons where generically named 2 so they reacted to the on_gui_click event from a button named 2.

I have a Pull Request ready and will attach it to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant