New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICO_Template.cs does not comply with the NEP-5 specification #22

Open

mwherman2000 opened this issue May 18, 2018 · 0 comments

mwherman2000 commented May 18, 2018 •

edited

Loading

https://github.com/neo-project/examples-csharp/blob/master/ICO_Template/ICO_Template.cs does not comply with the NEP-5 specification. For example all of the public NEP-5 methods should start with a lower case letter. There's issues with the lettercasing of the transfer event.

The sample also contains operations and methods that are extraneous to the NEP-5 specification.

The sample doesn't comply with NEP-10 in light of the above.

Reference:
neo-project/proposals#33

neo-project/proposals#44 (comment)

chenzhitong mentioned this issue

Add NEP-5 project, comply with the NEP-5 specification. #26

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment