New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Request #6 cannot be merged. #7

Open

chenzhitong opened this issue Sep 20, 2020 · 1 comment

Collaborator

chenzhitong commented Sep 20, 2020

这里应该检查所有的outputs，只有都满足条件才将 ifClaimGas 设置为 false；否则一个output满足就可以绕过这个检查，并没修复那个漏洞。
也许可以改为：

bool ifClaimGas = false;
foreach (var output in outputs)
{
    if (output.ScriptHash.AsBigInteger() != currentHash.AsBigInteger() || output.AssetId.AsBigInteger() != AssetId.AsBigInteger())
        ifClaimGas = true;

Originally posted by @chenzhitong in #6 (comment)

chenzhitong changed the title ~~Pull Request #6 cannot be mege.~~ Pull Request #6 cannot be merged.

Collaborator Author

chenzhitong commented Sep 20, 2020

We have to wait for Red4sec's audit before merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment