Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: learners of course API should return 404 if course is not valid #92

Open
shadinaif opened this issue Oct 8, 2024 · 0 comments
Open

bug: learners of course API should return 404 if course is not valid #92

shadinaif opened this issue Oct 8, 2024 · 0 comments
Assignees
@shadinaif @tehreem-sadat
Labels
important Takes priority over other tasks

Comments

@shadinaif
Copy link
Collaborator

shadinaif commented Oct 8, 2024 •
edited
Loading 

GET api/fx/learners/v1/learners/<course-id>/

the API returns an empty list like the following when the course doesn't exist

{
    "count": 0,
    "next": null,
    "previous": null,
    "results": []
}

it should return 404 instead
@shadinaif shadinaif self-assigned this Oct 8, 2024
@shadinaif shadinaif added the important Takes priority over other tasks label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shadinaif shadinaif

@tehreem-sadat tehreem-sadat

Labels
important Takes priority over other tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadinaif @tehreem-sadat