Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: SREI production instance shows all courses count even if they're for testing purposes #7

Closed
OmarIthawi opened this issue Apr 20, 2024 · 3 comments · Fixed by #6
Assignees
Labels
test on production Being tested on production server

Comments

@OmarIthawi
Copy link
Collaborator

Go to https://dashboard.futurex.sa/ and check SREI course results

Actual result: 17
Expected result: 3 (or anything other than 17)

image

@shadinaif
Copy link
Collaborator

shadinaif commented Apr 21, 2024

thank you @OmarIthawi . For now, I'll exclude all courses with catalog_visibility not in ('about', 'both'). That will make the value 4 (three active and one archived). Do you think we need a global filter in the dashboard to include/exclude hidden courses? like a checkbox somewhere on the page (not a settings,,, settings will be confusing and hard to find)

@shadinaif shadinaif linked a pull request Apr 21, 2024 that will close this issue
@OmarIthawi
Copy link
Collaborator Author

thank you @OmarIthawi . For now, I'll exclude all courses with catalog_visibility not in ('about', 'both'). That will make the value 4 (three active and one ended). Do you think we need a global filter in the dashboard to include/exclude hidden courses? like a checkbox somewhere on the page (not a settings,,, settings will be confusing and hard to find)

I think we should have as few settings as possible.

Your suggestion works regarding catelog_visibility.

@OmarIthawi
Copy link
Collaborator Author

@shadinaif kindly keep this issue open until it's closed in production. Last time I checked it's still an issue for SREI in https://dashboard.futurex.sa/ .

@shadinaif shadinaif added on staging Task is implemented and deployed to staging, but not to production test on production Being tested on production server and removed on staging Task is implemented and deployed to staging, but not to production labels Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test on production Being tested on production server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants