Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create queries for the 4th and 5th card with more context if data is partial #67

Open
OmarIthawi opened this issue Sep 8, 2024 · 10 comments
Assignees
Labels
important Takes priority over other tasks in progress Implemented in a PR but bot deployed to staging yet

Comments

@OmarIthawi
Copy link
Collaborator

OmarIthawi commented Sep 8, 2024

Same issue:

{ 'total_learners: 10,122, limited_access: true }
@OmarIthawi OmarIthawi changed the title feat: create queries for the 4th and 5th card feat: create queries for the 4th and 5th card with more context if data is partial Sep 25, 2024
@shadinaif
Copy link
Collaborator

resolved in #76

@shadinaif shadinaif added the in progress Implemented in a PR but bot deployed to staging yet label Sep 26, 2024
@OmarIthawi
Copy link
Collaborator Author

This has been partially resolved by #76, we need the following 5th statistic:

  • Total learning hours: Number of passing students * course.effort

We've shared this stat with the data team and it seems to be approved.

image

@shadinaif
Copy link
Collaborator

nice! thank you @OmarIthawi !

@OmarIthawi
Copy link
Collaborator Author

@shadinaif, please let me know when this is implemented in staging so we can add it the frontend.

@OmarIthawi OmarIthawi added the important Takes priority over other tasks label Dec 17, 2024
@OmarIthawi
Copy link
Collaborator Author

@tehreem-sadat Please let me know if you or Shadi can get to this task any time soon.

It's about time that we add this metric to our homepage so it looks complete :)

cc: @shadinaif

@tehreem-sadat
Copy link
Collaborator

@OmarIthawi started working on it yesterday, I;ll let you know when it is done.

@shadinaif
Copy link
Collaborator

@OmarIthawi as I remember from a previous discussion; the number of passing students is counted according to certificates. Please let us know if that changed for any reason

@OmarIthawi
Copy link
Collaborator Author

OmarIthawi commented Dec 19, 2024

@shadinaif I'm unsure what you mean.

All the existing cards are great!!

We need the fifth one as mentioned here #67 (comment)

This has been partially resolved by #76, we need the following 5th statistic:

  • Total learning hours: Number of passing students * course.effort

We've shared this stat with the data team and it seems to be approved.

image

I hope that makes it clearer

@shadinaif
Copy link
Collaborator

shadinaif commented Dec 19, 2024

@OmarIthawi I mean: your proposed equation contains Number of passing students. I remember we agreed that passing is simply having downloadable certificate, and the data team didn't see a problem with this concept. Has that changed since then?

@OmarIthawi
Copy link
Collaborator Author

having downloadable certificate

Yes, it's [having downloadable certificate] * course.effort.

Thanks for the calrification @shadinaif.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Takes priority over other tasks in progress Implemented in a PR but bot deployed to staging yet
Projects
None yet
Development

No branches or pull requests

3 participants