Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Share Mobile APIs commits on nelc/edx-platform with Andrey #162

Closed
OmarIthawi opened this issue Dec 6, 2024 · 2 comments
Closed
Assignees

Comments

@OmarIthawi
Copy link
Collaborator

OmarIthawi commented Dec 6, 2024

Due Date: 12-12-2024

I've cherry-picked many mobile API commits from Redwood and Sumac releases in the following two PRs:

Each PR contains many commits. Most of them are from Redwood, so they need no work.

However, some of those PRs are in Sumac only and needs to be cherry-picked again by Andrey and Johan into NeLC's Redwood branch.

Kindly check those pull requests and share the Sumac commits with Andrey either on Slack or in the following doucment:

@tehreem-sadat
Copy link
Collaborator

tehreem-sadat commented Dec 9, 2024

@shadinaif I fetch latest changes of edx-platform and ran following command to get all the commits that are on sumac and not on redwood:

git log origin/open-release/redwood.master..origin/open-release/sumac.master --oneline -- lms/djangoapps/mobile_api

8ddc58283f Merge pull request #34859 from raccoongang/kireiev/AXM-549/feat/upstream_PR_active_inactive_courses_API
13e3024ae3 style: [FC-0047] fix code style issues
9a0734b280 style: [FC-0047] add module docstrings
28eb406f8d feat: [FC-0047] add settings for edx-ace push notifications
b77b90a344 fix: Enable courseware access api for all types of course(expired, cl… (#35155)
3589d964cb feat: Added mobile api for course enrollment and other details. (#35100)
53174178f3 feat: [FC-0047] Extend mobile API with course progress and primary courses on dashboard view (#34848)
11626148d9 refactor: switch from mock to unittest.mock (#34844)

Afterwards, I reviewed the commits listed in the PRs shared by Omar, and found only one commit that is present in sumac, but not in redwood, and is also mentioned in the PRs shared by Omar.

53174178f3 feat: [FC-0047] Extend mobile API with course progress and primary courses on dashboard view (#34848)

@OmarIthawi
Copy link
Collaborator Author

Thanks @tehreem-sadat and @shadinaif.

Information was sent to the team. Closing this as done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants