Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core locking and composite builds #57

Open
OdysseusLives opened this issue Mar 19, 2019 · 1 comment
Open

Core locking and composite builds #57

OdysseusLives opened this issue Mar 19, 2019 · 1 comment

Comments

@OdysseusLives
Copy link
Member

Composite builds throw an error when I have locked all of my dependencies

Given that I am using Gradle core locks in the project composite
And I have locked my dependencies
When I define a composite build via settings.gradle
Then I expect my composite build to work without error

Actual behavior: I receive an error:

Could not determine the dependencies of task ':compileJava'.
> Could not resolve all task dependencies for configuration ':compileClasspath'.
   > Did not resolve 'gradle.nebula.integration:dependency-project:0.1.0' which is part of the dependency lock state

This looks to be captured in gradle/gradle/#4749

The issue is recreated in a project

@ljacomet
Copy link
Contributor

That is indeed a limitation of the current implementation.

Just to be clear as to what is the expected resolution. When including a build as part of a composite:

  1. the lock entry matching that project, and only that entry, should be ignored since the user clearly accepts to run with a different version.
  2. the lock entry matching that project and its dependencies should be ignored since the user runs with a live project instead of a binary.

For Gradle, only 1 makes sense but 2 shows it will have limited applicability.

Would fixing 1 be enough for your usage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants