Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo-Jupyter Scheduler parameters behave differently than Jupyter-Scheduler #2

Open
Tracked by #1838
ericdatakelly opened this issue Sep 21, 2023 · 1 comment
Labels
area: user experience 👩🏻‍💻 needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request

Comments

@ericdatakelly
Copy link

Describe the bug

I tried to demo the Jupyter Scheduler with a simple notebook that prints the value of parameter a, but it fails with the message "Workflow failed".
image

image

Expected behavior

The notebook should run the cell (print the value of a) and be available to download from the Notebook Jobs table. Note that Jupyter Scheduler will create a new cell at the top of the notebook and add the parameter.
image

image

OS and architecture in which you are running Nebari

ASW cloud

How to Reproduce the problem?

  1. Create a notebook with a single code cell containing print(a)
  2. Make sure your environment has papermill installed
  3. Click on the Jupyter Scheduler icon, choose your environment, add parameter a with value of 2 (or whatever number), choose Run now, click Create
  4. Reload the Notebook jobs table to refresh until the job is complete
  5. Check the status for "Failed" or "Completed". If completed, click the download arrow under "Output files" and check that the notebook printed the value of the parameter.

Command output

No traceback, just the failure message in the job output.

Versions and dependencies used.

Nebari v2023.7.2.dev60+gd58ebb1

Compute environment

AWS

Integrations

No response

Anything else?

No response

@ericdatakelly ericdatakelly added needs: triage 🚦 Someone needs to have a look at this issue and triage type: bug 🐛 Something isn't working labels Sep 21, 2023
@iameskild
Copy link
Member

Thanks for reporting this @ericdatakelly!

The Jupyter-Scheduler we're using is a modified version of Jupyter-Scheduler (we call it Argo-Jupyter-Scheduler), the parameter field works slightly differently. They get converted to environment variables that can be used as follows a = os.environ.get('a'). This is briefly mentioned in the docs here.

We can investigate what it would take to match the base Jupyter-Scheduler.

@iameskild iameskild changed the title [BUG] - Jupyter Scheduler failing Argo-Jupyter Scheduler parameters behave differently than Jupyter-Scheduler Sep 21, 2023
@iameskild iameskild added area: user experience 👩🏻‍💻 needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug and removed type: bug 🐛 Something isn't working needs: triage 🚦 Someone needs to have a look at this issue and triage labels Sep 21, 2023
@pavithraes pavithraes added the type: enhancement 💅🏼 New feature or request label Sep 25, 2023
@iameskild iameskild transferred this issue from nebari-dev/nebari Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 needs: investigation 🔍 Someone in the team needs to find the root cause and replicate this bug type: enhancement 💅🏼 New feature or request
Projects
Status: New 🚦
Development

No branches or pull requests

3 participants