Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to how default acls are handled #4

Open
Jamstah opened this issue Jan 30, 2019 · 1 comment
Open

Change to how default acls are handled #4

Jamstah opened this issue Jan 30, 2019 · 1 comment

Comments

@Jamstah
Copy link
Contributor

Jamstah commented Jan 30, 2019

Having just played with this code, I'd like to suggest a change to how default acls are handled. Technically, the ACL and Default ACL for a directory are two different resources, so I think something like this would be better:

acl /tmp/directory do
  user 'rwx'
  group '': 'r-x', testgroup: 'rwx'
  mask 'rwx'
end
default_acl /tmp/directory do
  user 'rwx'
  group '': 'r-x', testgroup: 'rwx'
  mask 'rwx'
end

That would also allow for having an action :remove to remove acls or default acls individually.

I might be able to do the work, and would also recommend being able to accept the current form with a deprecation warning. Didn't want to do the work and submit a PR without having a design discussion though.

@vnaipaul
Copy link

What about letting the default property be a boolean as well as a Hash, while deprecating the Hash form ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants