Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moduleResolution as bundle #388

Open
antonioconselheiro opened this issue Mar 18, 2024 · 8 comments
Open

moduleResolution as bundle #388

antonioconselheiro opened this issue Mar 18, 2024 · 8 comments

Comments

@antonioconselheiro
Copy link
Contributor

antonioconselheiro commented Mar 18, 2024

NIPs that are not exported by default depend on the typescript configuration moduleResolution set as bundle.

image

I'm suggesting that it would be a good idea to include information about the need for this configuration in readme.md.

Maybe it's something obvious that I didn't understand, but it took me a while to understand out how to import these modules:

https://njump.me/note1d750tkpzs6lh5260x0z3r7w2n79ek82r9mg0kazmp6nms0ys8k9stvntte

@fiatjaf
Copy link
Collaborator

fiatjaf commented Mar 18, 2024

I am sorry, but the JavaScript ecosystem is ridiculous. The way dependencies and package managers and preprocessers and bundlers interact with each other changes all the time in a way that is not sane and this repository cannot help with that.

Maybe we should add a note saying that you are expected to have a PhD in Javascript Sciences before using the package?

@alexgleason
Copy link
Collaborator

Sorry, I may have broken it here: db53f37 Did not realize that would affect downstream packages. This is the correct setting for modern TypeScript, though.

@alexgleason
Copy link
Collaborator

It seems like we could change it to nodenext to make it work both ways.

@antonioconselheiro
Copy link
Contributor Author

Just a suggestion, if you think it doesn't apply we can close the issue.

@alexgleason
Copy link
Collaborator

Nah you're probably not the only person going to experience this issue. I changed it to NodeNext in 6b43533 just now. Hopefully that will fix this issue.

@antonioconselheiro
Copy link
Contributor Author

if these changes are confirmed I will no longer need my configuration moduleResolution set as bundle in my project?

@alexgleason
Copy link
Collaborator

You should still be using NodeNext or Bundler for modern projects. There's no reason to go back if you got it working. But I'm trying to fix it so it'll work both ways.

@alexgleason
Copy link
Collaborator

I think my commit will fix it. We need another version deployed to test it out.

@fiatjaf I ended up ripping out the GitHub actions for JSR because it's not working. I'll fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants