Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INTERNAL: Refactor lq_detect_buffer struct #808

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

cheesecrust
Copy link

@cheesecrust cheesecrust commented Nov 27, 2024

🔗 Related Issue

⌨️ What I did

  • 기존 lq_detect_buffer의 data에 출력될 문자열을 미리 붙인 후 출력하는 방식에서 lq_detect_argument에서 client_ip, time 을 가지고 있다가 마지막에 합쳐서 출력하는 형태로 변경하였습니다.
  • 이에 맞추어 기존에 출력하려던 버퍼를 LQ_INPUT_SIZE로 최대로 잡는 방식에서 실제로 출력할 문자열의 길이만큼만 할당하도록 변경하였습니다.
  • 따라서 추후 key size 등이 증가하여도 추가적인 변경없이 확장 할 수 있습니다.

@cheesecrust cheesecrust marked this pull request as draft November 27, 2024 05:13
@cheesecrust cheesecrust force-pushed the internal/lqdetect_buffer_struct branch from 1776f4f to 9edd738 Compare November 27, 2024 05:30
@cheesecrust cheesecrust marked this pull request as ready for review November 27, 2024 05:34
@jhpark816
Copy link
Collaborator

@cheesecrust @namsic
본 PR보다는 기존 구현이 나은 것 같습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants