Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Fix node_name buffer size #798

Merged
merged 1 commit into from
Nov 5, 2024
Merged

FIX: Fix node_name buffer size #798

merged 1 commit into from
Nov 5, 2024

Conversation

cheesecrust
Copy link

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • ํ˜„์žฌ snprintf์˜ ๋ฐ˜ํ™˜๊ฐ’์„ ๊ทธ๋Œ€๋กœ ์“ฐ์—ฌ์ง„ ๋ฌธ์ž์—ด์˜ ๊ธธ์ด๋กœ ๊ฐ„์ฃผํ•˜์—ฌ ํ•ด์‹ฑ์„ ํ•˜๋Š”๋ฐ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
  • ์ด์— snprintf์˜ ๋ฐ˜ํ™˜๊ฐ’์ด ์‹ค์ œ๋กœ ์“ฐ์—ฌ์ง„ ๋ฌธ์ž์—ด์˜ ๊ธธ์ด๋ณด๋‹ค ํด ๊ฒฝ์šฐ ํ•ด์‹ฑ ๋„์ค‘์— ์ž˜๋ชป๋œ ์ฃผ์†Œ๋ฅผ ์ฐธ์กฐํ•  ์ˆ˜ ๋„ ์žˆ๊ณ , ์›ํ•˜๋Š”๋ฐ๋กœ ํ•ด์‹ฑ์ด ์ด๋ฃจ์–ด์ง€์ง€ ์•Š์„ ์šฐ๋ ค๊ฐ€ ์žˆ์Šต๋‹ˆ๋‹ค.
  • ๋”ฐ๋ผ์„œ ๋ฒ„ํผ์˜ ํฌ๊ธฐ๋ฅผ node_name์„ ์ง€์„ ์ˆ˜ ์žˆ๋Š” ์ตœ์žฅ ๊ธธ์ด๋กœ ์„ค์ •ํ•˜์—ฌ ์œ„์˜ ์˜ˆ์™ธ๋“ค์„ ํ”ผํ•˜๊ณ ์ž ํ•ฉ๋‹ˆ๋‹ค.

@jhpark816 jhpark816 merged commit 27aed33 into naver:develop Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namsic namsic namsic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheesecrust @namsic @jhpark816