Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listnames rpc method #924

Open
sakdeniz opened this issue Feb 5, 2022 · 11 comments · May be fixed by #937
Open

Add listnames rpc method #924

sakdeniz opened this issue Feb 5, 2022 · 11 comments · May be fixed by #937

Comments

@sakdeniz
Copy link

sakdeniz commented Feb 5, 2022

Currently, there is no rpc method where we can see the list of registered names. I think it is necessary to add the listnames rpc method.

@mxaddict
Copy link
Contributor

mxaddict commented Feb 5, 2022

Just list all dotNAV names?

@sakdeniz
Copy link
Author

sakdeniz commented Feb 5, 2022

List all dotNAV names with subdomains and key, value pairs like resolvename.

@aguycalled
Copy link
Member

listing all the names with their entries can be a lot of data to transmit, might be better to only do it with the names imo

@sakdeniz
Copy link
Author

sakdeniz commented Feb 6, 2022

So, its better to add mine parameter for filtering user owned domains or restrict method to only user owned domains with their entries.

@aguycalled
Copy link
Member

I think even with the filter, it is more efficient to only show the names, letting the client to later resolve individually if needed.

@sakdeniz
Copy link
Author

sakdeniz commented Feb 6, 2022

If it's going to be a serious performance issue, what you said might make sense. It would be better to be able to get all domains and subdomains information at once if there is no delay.

@mxaddict
Copy link
Contributor

@sakdeniz I'm working on this now along side the nftindex

@mxaddict mxaddict linked a pull request Mar 11, 2022 that will close this issue
@prashantbarge22
Copy link

If it's going to be a serious performance issue, what you said might make sense. It would be better to be able to get all domains and subdomains information at once if there is no delay.

Might be a solution
Why don't maintain a cookie in the local Storage in the client, and regularly update it after a interval?

@mxaddict
Copy link
Contributor

This patch has been updated to only list your own domains/subdomains, so it won't be too many to list.

@prashantbarge22
Copy link

This patch has been updated to only list your own domains/subdomains, so it won't be too many to list.

Can you please help me with starting this project in windows as i am unable to do it

@mxaddict
Copy link
Contributor

I'm not sure windows will be a good Idea for compiling this project, I would suggest running a linux VM.

I would suggest either VM Ware Player or Virtual Box, then install Ubuntu 20.04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants