Add resolvename subdomains #916
Conversation
mxaddict
force-pushed
the
add-resolvename-subdomains
branch
from
614b4b5 to
302395c
Compare
|
A new build of 302395c has completed succesfully! |
Alright, I'll add it now, should it not allow it? Or just ignore the second param? |
|
maybe it's enough just ignoring it |
src/wallet/rpcwallet.cpp
Outdated
| } | ||
| } | ||
|
|
||
| if (getSubdomains && subdomain != "") { |
There was a problem hiding this comment.
@aguycalled I added this check, should be good?
|
i thought that each dotnav can only have one subdomain? so there wouldn't be subdomains |
|
A new build of b8b7ff3 has completed succesfully! |
|
Yes, that is why we needed to add the check logic.
…On Sun, Jan 23, 2022, 12:17 chasingkirkjufell ***@***.***> wrote:
i thought that each dotnav can only have one subdomain? so there wouldn't
be subdomains
—
Reply to this email directly, view it on GitHub
<#916 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIDAKL2B6TKTJUUWQJ3WZLUXN6M7ANCNFSM5MRYVYGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I can't resolve subdomain with true unless directly resolving subdomain. did i do it wrong? i'm on b8b7ff3 windows 10 gitian build |
Yes, we can't have second level subdomains, that is why we just ignore the subdomain request on a subdomain |
|
In my screenshot I was trying to resolve first level subdomain with true on the original domain but it didnt work. Can only resolve subdomain directly. |
|
I'll double check |
|
@chasingkirkjufell I've fixed the issue that you mentioned |
|
A new build of 555fa81 has completed succesfully! |
closes #911