Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use random key instead of blinding key pool when constructing candidate tx #809

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Use random key instead of blinding key pool when constructing candidate tx #809

merged 2 commits into from
Apr 8, 2021

Conversation

aguycalled
Copy link
Member

Fixes #807

@navbuilder
Copy link

A new build of 5874c7c has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-807

@aguycalled aguycalled mentioned this pull request Mar 11, 2021
Closed
@mxaddict
Copy link
Contributor

@aguycalled how do we test this change?

@aguycalled
Copy link
Member Author

it can be tested by checking that xnav candidate txes correctly propagate and aggregation works

@mxaddict
Copy link
Contributor

mxaddict commented Mar 15, 2021 via email

@navbuilder
Copy link

A new build of 0530166 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-807

chasingkirkjufell
chasingkirkjufell approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested private transactions on windows 10 with gitian build

@mxaddict mxaddict merged commit 5f0ec7d into navcoin:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@mxaddict mxaddict mxaddict approved these changes

@0x2830 0x2830 Awaiting requested review from 0x2830

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

excessive logging in error.log when wallet locked with xNAV balance
4 participants
@aguycalled @navbuilder @mxaddict @chasingkirkjufell