Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derivation path #495

Open
aguycalled opened this issue May 22, 2019 · 13 comments
Open

Derivation path #495

aguycalled opened this issue May 22, 2019 · 13 comments

Comments

@aguycalled
Copy link
Member

aguycalled commented May 22, 2019

Currently navcoin core shares with bitcoin the derivation path used for the generation of new addresses (m/0'/0'), this should be changed to m/44'/130' while preserving backwards compatibility with old wallets.

@mxaddict
Copy link
Contributor

@aguycalled we should add an issue over at NavPay as well, and Next?

We only have 3 wallets to update right?

NEXT uses core? So do we have anything to change on that end?

@aguycalled
Copy link
Member Author

NEXT uses core, NavPay should see an issue opened too

@mxaddict
Copy link
Contributor

NEXT uses core, NavPay should see an issue opened too

ACK

@mxaddict
Copy link
Contributor

I think NavPay is easier as it's just changing the default on creation and the default on import

Then adding a note on import page.

@mxaddict
Copy link
Contributor

I think NavPay is easier as it's just changing the default on creation and the default on import

Then adding a note on import page.

This statement was WRONG 👍

@alexeyneu
Copy link
Contributor

i do not see anything on this here: https://github.com/bitcoin/bips/blob/master/bip-0130.mediawiki
so you're talkin about m/44'/130'

@alexeyneu
Copy link
Contributor

and i found this:

// for now we use a fixed keypath scheme of m/0'/0'/k

so what is it you finally wanna?

@aguycalled
Copy link
Member Author

aguycalled commented Jun 1, 2019

you are right, updated issue description

@alexeyneu
Copy link
Contributor

alexeyneu commented Jun 2, 2019

Currently navcoin core shares with bitcoin the derivation path used for the generation of new addresses (m/0'/0'), this should be changed to m/44'/130' while preserving backwards compatibility with old wallets.

it'll be 44'/130'/0'/0'/0'
in 44'/130'/0' all three lose its meanings

EDIT:
you can go with letter stuff

@mxaddict
Copy link
Contributor

mxaddict commented Jun 3, 2019

@alexeyneu What do you mean by "letter stuff"

@mxaddict
Copy link
Contributor

@alexeyneu are you working on this? If so I can assign this issue to you.

@alexeyneu
Copy link
Contributor

alexeyneu commented Jun 14, 2019

may be i'll do it , may be not
the bad is that you'd to add mnemonic early . And now all this deriv path stuff goes straight to user coz no one knows what he'd used to export it.
say in mew during import you choose path used , but before that you did it on export . So how i see it is to add option to importmnemonic like -before17 .
on the other hand it's new stuff so is not being used by many.

@mxaddict
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants
@mxaddict @aguycalled @alexeyneu and others