From fbcacd4cf0dbe54e51f89cda05ff3db9e378ea12 Mon Sep 17 00:00:00 2001 From: Martin Zumsande Date: Fri, 1 Sep 2023 14:33:39 -0400 Subject: [PATCH] test: remove fixed timeouts from feature_config_args They cannot be scaled by the timeout_factor option and can therefore cause timeouts in slow environments. They are also not necessary for the test, since they measure time frome startup until a debug message is encountered, which is not restricted to 1 minute by any internal logic within bitcoind. --- test/functional/feature_config_args.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/test/functional/feature_config_args.py b/test/functional/feature_config_args.py index 3056288053e26..97ee9538dcb4d 100755 --- a/test/functional/feature_config_args.py +++ b/test/functional/feature_config_args.py @@ -249,28 +249,24 @@ def test_seed_peers(self): # No peers.dat exists and -dnsseed=0 # We expect the node will fallback immediately to fixed seeds assert not os.path.exists(os.path.join(default_data_dir, "peers.dat")) - start = time.time() with self.nodes[0].assert_debug_log(expected_msgs=[ "Loaded 0 addresses from peers.dat", "DNS seeding disabled", "Adding fixed seeds as -dnsseed=0 (or IPv4/IPv6 connections are disabled via -onlynet) and neither -addnode nor -seednode are provided\n", ]): self.start_node(0, extra_args=['-dnsseed=0', '-fixedseeds=1']) - assert time.time() - start < 60 self.stop_node(0) self.nodes[0].assert_start_raises_init_error(['-dnsseed=1', '-onlynet=i2p', '-i2psam=127.0.0.1:7656'], "Error: Incompatible options: -dnsseed=1 was explicitly specified, but -onlynet forbids connections to IPv4/IPv6") # No peers.dat exists and dns seeds are disabled. # We expect the node will not add fixed seeds when explicitly disabled. assert not os.path.exists(os.path.join(default_data_dir, "peers.dat")) - start = time.time() with self.nodes[0].assert_debug_log(expected_msgs=[ "Loaded 0 addresses from peers.dat", "DNS seeding disabled", "Fixed seeds are disabled", ]): self.start_node(0, extra_args=['-dnsseed=0', '-fixedseeds=0']) - assert time.time() - start < 60 self.stop_node(0) # No peers.dat exists and -dnsseed=0, but a -addnode is provided