Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add ESLint and Prettier for standardization #18

Closed
wants to merge 4 commits into from
Closed

fix: Add ESLint and Prettier for standardization #18

wants to merge 4 commits into from

Conversation

Vinitvh
Copy link

@Vinitvh Vinitvh commented Oct 11, 2022

  • Added ESLint with script lint:fix: "eslint . --fix" which checks for linting problems.
  • Added Prettier with script format: "prettier . --write" which formats code according to config.

closes #17

@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-landing-vpn ❌ Failed (Inspect) Oct 25, 2022 at 7:01AM (UTC)

@naufaldi
Copy link
Owner

  1. Can you provide screenshot if ESLint and Prettier work with script?
  2. Can you use npm not yarn and not uploaded yarn.lock file?

@Vinitvh
Copy link
Author

Vinitvh commented Oct 12, 2022

This is the screenshot for ESLint script.
lint

This is the screenshot for prettier script.
prettier

  • Both yarn and npm can be used.

@naufaldi
Copy link
Owner

can you resolve conflict and make file not error when production @Vinitvh ?

@Vinitvh
Copy link
Author

Vinitvh commented Oct 25, 2022

Hi @naufaldi, looks like I'm having issues solving merge conflicts. Sorry for that. Will try to resolve those as soon as possible.

@Vinitvh Vinitvh closed this by deleting the head repository Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linter
2 participants