From d46ce9e38bdf0ee651256eed11b1d2e3eebf10ce Mon Sep 17 00:00:00 2001
From: corot <jorge.santos@rapyuta-robotics.com>
Date: Tue, 25 Jul 2023 09:47:38 +0900
Subject: [PATCH] Add TODO comment explaining issue #323

---
 .../include/mbf_abstract_nav/abstract_action_base.hpp            | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mbf_abstract_nav/include/mbf_abstract_nav/abstract_action_base.hpp b/mbf_abstract_nav/include/mbf_abstract_nav/abstract_action_base.hpp
index 3e009dba..f5bdbb8b 100644
--- a/mbf_abstract_nav/include/mbf_abstract_nav/abstract_action_base.hpp
+++ b/mbf_abstract_nav/include/mbf_abstract_nav/abstract_action_base.hpp
@@ -143,6 +143,7 @@ class AbstractActionBase
         // if there is already a plugin running on the same slot, cancel it
         slot_it->second.execution->cancel();
 
+        // TODO + WARNING: this will block the main thread for an arbitrary time during which we won't execute callbacks
         if (slot_it->second.thread_ptr->joinable()) {
           slot_it->second.thread_ptr->join();
         }