From 3de31c622b8b1e006ba6dd31c701435d6212a58d Mon Sep 17 00:00:00 2001
From: Alexander Mock <amock@uos.de>
Date: Thu, 12 Dec 2024 00:52:40 +0100
Subject: [PATCH] properly inititalized for loop id. added std namespace to
 strings

---
 mesh_msgs_conversions/src/conversions.cpp | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/mesh_msgs_conversions/src/conversions.cpp b/mesh_msgs_conversions/src/conversions.cpp
index 16a9e65..4830dd3 100644
--- a/mesh_msgs_conversions/src/conversions.cpp
+++ b/mesh_msgs_conversions/src/conversions.cpp
@@ -239,11 +239,10 @@ bool fromMeshGeometryToMeshBuffer(
     const mesh_msgs::msg::MeshGeometry& mesh_geometry,
     lvr2::MeshBuffer& buffer)
 {
-
     const size_t numVertices = mesh_geometry.vertices.size();
     lvr2::floatArr vertices( new float[ numVertices * 3 ] );
     const auto& mg_vertices = mesh_geometry.vertices;
-    for(size_t i; i<numVertices; i++)
+    for(size_t i = 0; i<numVertices; i++)
     {
         vertices[ i * 3 + 0 ] = static_cast<float>(mg_vertices[i].x);
         vertices[ i * 3 + 1 ] = static_cast<float>(mg_vertices[i].y);
@@ -254,7 +253,7 @@ bool fromMeshGeometryToMeshBuffer(
     const size_t numFaces = mesh_geometry.faces.size();
     lvr2::indexArray faces( new unsigned int[ numVertices * 3 ] );
     const auto& mg_faces = mesh_geometry.faces;
-    for(size_t i; i<numFaces; i++)
+    for(size_t i = 0; i<numFaces; i++)
     {
         faces[ i * 3 + 0 ] = mg_faces[i].vertex_indices[0];
         faces[ i * 3 + 1 ] = mg_faces[i].vertex_indices[1];
@@ -265,7 +264,7 @@ bool fromMeshGeometryToMeshBuffer(
     const size_t numNormals = mesh_geometry.vertex_normals.size();
     lvr2::floatArr normals( new float[ numNormals * 3 ] );
     const auto& mg_normals = mesh_geometry.vertex_normals;
-    for(size_t i; i<numNormals; i++)
+    for(size_t i = 0; i<numNormals; i++)
     {
         normals[ i * 3 + 0 ] = static_cast<float>(mg_normals[i].x);
         normals[ i * 3 + 1 ] = static_cast<float>(mg_normals[i].y);
@@ -276,7 +275,7 @@ bool fromMeshGeometryToMeshBuffer(
     return true;
 }
 
-bool readMeshBuffer(lvr2::MeshBufferPtr& buffer_ptr, string path)
+bool readMeshBuffer(lvr2::MeshBufferPtr& buffer_ptr, std::string path)
 {
     lvr2::ModelFactory io_factory;
     lvr2::ModelPtr model = io_factory.readModel(path);
@@ -292,7 +291,7 @@ bool readMeshBuffer(lvr2::MeshBufferPtr& buffer_ptr, string path)
     }
 }
 
-bool writeMeshBuffer(lvr2::MeshBufferPtr& buffer, string path)
+bool writeMeshBuffer(lvr2::MeshBufferPtr& buffer, std::string path)
 {
     lvr2::ModelPtr model(new lvr2::Model(buffer));
     lvr2::ModelFactory::saveModel(model, path);