Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to consumer info casing in output #796

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jun 3, 2023

Some updates to consumer info command

before:

State:

  Last Delivered Message: Consumer sequence: 1 Stream sequence: 1 Last delivery: 14m42s ago
    Acknowledgment floor: Consumer sequence: 1 Stream sequence: 1 Last Ack: 14m42s ago
        Outstanding Acks: 0 out of maximum 1,000
    Redelivered Messages: 0
    Unprocessed Messages: 0
           Waiting Pulls: 0 of maximum 512

after:

State:

  Last Delivered Message: Consumer sequence: 1 Stream sequence: 1 Last delivery: 14m29s ago
    Acknowledgment Floor: Consumer sequence: 1 Stream sequence: 1 Last ack: 14m29s ago
        Outstanding Acks: 0 out of maximum 1,000
    Redelivered Messages: 0
    Unprocessed Messages: 0
           Waiting Pulls: 0 of maximum 512

Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar ripienaar merged commit cca19f4 into main Aug 8, 2023
4 checks passed
@ripienaar ripienaar deleted the consumer-info-output branch August 8, 2023 07:59
@wallyqs
Copy link
Member Author

wallyqs commented Sep 20, 2023

I was checking just in case but this silly change got reverted here in a following commit: 2cc0f18#diff-5f4db62e1562fa119614c73fce2b6bc5d8fa55868b7c98cd177c1847a3889158R663

@ripienaar
Copy link
Collaborator

Hmm, yours is still in main here:

https://github.com/nats-io/natscli/blame/f77374d50d882f73f4cab62b15f4ce8804c7bb8f/cli/consumer_command.go#L663

and the other one is also in main though harder to see where it went back in, I recall seeing it got undone but too much code changes for a nice fix.

cols.AddRowf("Acknowledgment Floor", "Consumer sequence: %s Stream sequence: %s", f(state.AckFloor.Consumer), f(state.AckFloor.Stream))
} else {
cols.AddRowf("Acknowledgment Floor", "Consumer sequence: %s Stream sequence: %s Last Ack: %s ago", f(state.AckFloor.Consumer), f(state.AckFloor.Stream), f(sinceRefOrNow(state.TimeStamp, *state.AckFloor.Last)))

@wallyqs
Copy link
Member Author

wallyqs commented Sep 20, 2023

ah got it, thanks for checking! should have checked main instead… 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants