feat: Add version metric #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcaflc
requested review from
janlauber,
svengerber,
janfuhrer and
Joel-Haeberli
as code owners
|
hi @lcaflc Can you please already sign all commits (according https://github.com/natrontech/pbs-exporter/blob/main/CONTRIBUTING.md#commit-signature-verification)? |
|
I'll sign the commits, sorry for that must check why git didn't have done it by default... |
Signed-off-by: Laurent Corbes <[email protected]>
Signed-off-by: Laurent Corbes <[email protected]>
Signed-off-by: Laurent Corbes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add support for version metrics retrieved from PBS API.
Notes for Reviewer:
We have to set the version as a label because this is not a "metric". This mimic what is done with the pve_exporter https://github.com/prometheus-pve/prometheus-pve-exporter
Checklist:
feat|fix|chore|docs|...: Changed SomethingREADME.mdfile (e.g. new parameters, environment variables, return values, ...)