Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update godot-cpp to 4.1 latest, (4.1.3) and fix up register_types.cpp #8

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

Squatnet
Copy link
Contributor

@Squatnet Squatnet commented Nov 21, 2023

4.1 changes

GDExtensionBool GDE_EXPORT example_library_init(const GDExtensionInterface *p_interface, GDExtensionClassLibraryPtr p_library, GDExtensionInitialization *r_initialization) {
	godot::GDExtensionBinding::InitObject init_obj(p_interface, p_library, r_initialization);

to

GDExtensionBool GDE_EXPORT example_library_init(GDExtensionInterfaceGetProcAddress p_get_proc_address, GDExtensionClassLibraryPtr p_library, GDExtensionInitialization *r_initialization) {
	godot::GDExtensionBinding::InitObject init_obj(p_get_proc_address, p_library, r_initialization);

@nathanfranke nathanfranke merged commit 8e09597 into nathanfranke:main Nov 21, 2023
4 of 5 checks passed
@nathanfranke
Copy link
Owner

I am going to try updating android builds shortly. Thanks for the contribution!

@Squatnet
Copy link
Contributor Author

i noticed after i pushed this that it still doesnt work correctly.
the .gdextension file needs a compatibility_minimum property and all paths to libraries are now specified as absolute paths,
i guess so the bin folder can be outside the addon folder.

[configuration]

entry_symbol = "gdextension_init"
compatibility_minimum = 4.1
[libraries]

macos.debug = "res://addons/example/bin/libexample.macos.debug.framework"
macos.release = "res://addons/example/bin/libexample.macos.release.framework"
windows.debug.x86_64 = "res://addons/example/bin/libexample.windows.debug.x86_64.dll"
windows.release.x86_64 = "res://addons/example/bin/libexample.windows.release.x86_64.dll"
linux.debug.x86_64 = "res://addons/example/bin/libexample.linux.debug.x86_64.so"
linux.release.x86_64 = "res://addons/example/bin/libexample.linux.release.x86_64.so"
linux.debug.arm64 = "res://addons/example/bin/libexample.linux.debug.arm64.so"
linux.release.arm64 = "res://addons/example/bin/libexample.linux.release.arm64.so"
linux.debug.rv64 = "res://addons/example/bin/libexample.linux.debug.rv64.so"
linux.release.rv64 = "res://addons/example/bin/libexample.linux.release.rv64.so"

happy to help, apologies for the oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants